pihkaal/pihkaal-me
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: implement some TODOs

Browse Source
This commit is contained in:
Stevan
2026-01-30 23:22:21 +01:00
parent 776783237b
commit 6e1a9a4728
6 changed files with 7 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/components/Achievements/TopScreen.vue
View File

@@ -37,7 +37,7 @@ onRender((ctx) => {
); );
// progress text // progress text
const unlockedCount = achievementsStore.achievements.length; const unlockedCount = achievementsStore.unlocked.length;
const totalCount = ACHIEVEMENTS.length; const totalCount = ACHIEVEMENTS.length;
ctx.font = "7px NDS7"; ctx.font = "7px NDS7";

2
app/components/Contact/BottomScreen/BottomScreen.vue
View File

@@ -1,6 +1,4 @@
<script setup lang="ts"> <script setup lang="ts">
// TODO: buttons should take in account opacity
import Background from "./Background.vue"; import Background from "./Background.vue";
import Buttons from "./Buttons.vue"; import Buttons from "./Buttons.vue";
import ButtonSelector from "~/components/Common/ButtonSelector.vue"; import ButtonSelector from "~/components/Common/ButtonSelector.vue";

2
app/components/Settings/BottomScreen/Menus/Clock/Achievements.vue
View File

@@ -110,7 +110,7 @@ onRender((ctx) => {
<template> <template>
<NumberInput <NumberInput
:model-value="achievements.achievements.length" :model-value="achievements.unlocked.length"
:title="$t('settings.clock.achievements.obtained')" :title="$t('settings.clock.achievements.obtained')"
:x="4 * 16 - 1" :x="4 * 16 - 1"
:selected="achievements.allObtained" :selected="achievements.allObtained"

10
app/components/Settings/BottomScreen/Menus/User/PersonalMessage.vue
View File

@@ -16,15 +16,11 @@ const handleCancel = () => {
switch (state.value) { switch (state.value) {
case "alive": { case "alive": {
state.value = "pause"; state.value = "pause";
// TODO: onClosed should as "choice" as a parameter, like "confirmed" or "canceled"
let quit = false;
confirmationModal.open({ confirmationModal.open({
text: $t("settings.user.personalMessage.quitConfirmation"), text: $t("settings.user.personalMessage.quitConfirmation"),
onConfirm: () => { onConfirm: () => {},
quit = true; onClosed: (choice) => {
}, if (choice === "cancel") store.closeSubMenu();
onClosed: () => {
if (quit) store.closeSubMenu();
}, },
onCancel: () => { onCancel: () => {
state.value = "alive"; state.value = "alive";

3
app/stores/achievements.ts
View File

@@ -72,8 +72,7 @@ export const useAchievementsStore = defineStore("achievements", () => {
}; };
return { return {
// TODO: rename to unlocked unlocked: computed(() => storage.value.unlocked),
achievements: computed(() => storage.value.unlocked),
advancement: computed(() => storage.value.advancement), advancement: computed(() => storage.value.advancement),
allObtained: computed( allObtained: computed(
() => storage.value.unlocked.length === ACHIEVEMENTS.length, () => storage.value.unlocked.length === ACHIEVEMENTS.length,

10
app/stores/confirmationModal.ts
View File

@@ -96,15 +96,7 @@ export const useConfirmationModal = defineStore("confirmationModal", {
}) })
.call(() => { .call(() => {
const closedCallback = this.onClosed; const closedCallback = this.onClosed;
this.$reset();
// TODO: this.$reset() ?
this.isVisible = false;
this.isClosing = false;
this.isOpen = false;
this.text = "";
this.onConfirm = null;
this.onClosed = null;
closedCallback?.(choice); closedCallback?.(choice);
}); });
}, },