From 5a023749ad87dbbe346c185dbe65bff44b2c0a94 Mon Sep 17 00:00:00 2001
From: Pihkaal <hello@pihkaal.me>
Date: Sat, 27 Dec 2025 16:45:37 +0100
Subject: [PATCH] feat(screen): remove useUpdate callback and add delta time to
 useRender

---
 app/components/Screen.vue    | 14 +-------------
 app/components/Stats.vue     |  4 +---
 app/composables/useRender.ts |  6 +++++-
 app/composables/useUpdate.ts | 18 ------------------
 4 files changed, 7 insertions(+), 35 deletions(-)
 delete mode 100644 app/composables/useUpdate.ts

diff --git a/app/components/Screen.vue b/app/components/Screen.vue
index dd23cda..6a2f41d 100644
--- a/app/components/Screen.vue
+++ b/app/components/Screen.vue
@@ -1,7 +1,6 @@
 <script lang="ts" setup>
 const canvas = useTemplateRef("canvas");
 
-const updateCallbacks = new Set<UpdateCallback>();
 const renderCallbacks = new Set<RenderCallback>();
 const screenClickCallbacks = new Set<ScreenClickCallback>();
 const screenMouseWheelCallbacks = new Set<ScreenMouseWheelCallback>();
@@ -11,11 +10,6 @@ let animationFrameId: number | null = null;
 let lastFrameTime = 0;
 let lastRealFrameTime = 0;
 
-const registerUpdateCallback = (callback: UpdateCallback) => {
-  updateCallbacks.add(callback);
-  return () => updateCallbacks.delete(callback);
-};
-
 const registerRenderCallback = (callback: RenderCallback) => {
   renderCallbacks.add(callback);
   return () => renderCallbacks.delete(callback);
@@ -62,18 +56,13 @@ const renderFrame = (timestamp: number) => {
 
   const start = Date.now();
 
-  // update
-  for (const callback of updateCallbacks) {
-    callback(deltaTime, lastRealFrameTime);
-  }
-
   // render
   ctx.clearRect(0, 0, SCREEN_WIDTH, SCREEN_HEIGHT);
 
   for (const callback of renderCallbacks) {
     ctx.save();
 
-    callback(ctx);
+    callback(ctx, deltaTime, lastRealFrameTime);
 
     ctx.restore();
   }
@@ -83,7 +72,6 @@ const renderFrame = (timestamp: number) => {
   animationFrameId = requestAnimationFrame(renderFrame);
 };
 
-provide("registerUpdateCallback", registerUpdateCallback);
 provide("registerRenderCallback", registerRenderCallback);
 provide("registerScreenClickCallback", registerScreenClickCallback);
 provide("registerScreenMouseWheelCallback", registerScreenMouseWheelCallback);
diff --git a/app/components/Stats.vue b/app/components/Stats.vue
index e15b953..26da811 100644
--- a/app/components/Stats.vue
+++ b/app/components/Stats.vue
@@ -8,7 +8,7 @@ const SAMPLES = 60;
 let average = { deltaTime: 0, realDeltaTime: 0 };
 const lastFrames: (typeof average)[] = [];
 
-useUpdate((deltaTime, realDeltaTime) => {
+useRender((ctx, deltaTime, realDeltaTime) => {
   lastFrames.push({ deltaTime, realDeltaTime });
 
   if (lastFrames.length > SAMPLES) {
@@ -24,9 +24,7 @@ useUpdate((deltaTime, realDeltaTime) => {
         lastFrames.length,
     };
   }
-});
 
-useRender((ctx) => {
   const LINE_COUNT = 5;
   const LINE_HEIGHT = 12;
 
diff --git a/app/composables/useRender.ts b/app/composables/useRender.ts
index ef4d5f1..8f66a2e 100644
--- a/app/composables/useRender.ts
+++ b/app/composables/useRender.ts
@@ -1,4 +1,8 @@
-export type RenderCallback = (ctx: CanvasRenderingContext2D) => void;
+export type RenderCallback = (
+  ctx: CanvasRenderingContext2D,
+  deltaTime: number,
+  realDeltaTime: number,
+) => void;
 
 export const useRender = (callback: RenderCallback) => {
   const registerRenderCallback = inject<
diff --git a/app/composables/useUpdate.ts b/app/composables/useUpdate.ts
deleted file mode 100644
index 79bd636..0000000
--- a/app/composables/useUpdate.ts
+++ /dev/null
@@ -1,18 +0,0 @@
-export type UpdateCallback = (deltaTime: number, realFrameTime: number) => void;
-
-export const useUpdate = (callback: UpdateCallback) => {
-  const registerUpdateCallback = inject<
-    (callback: UpdateCallback) => () => void
-  >("registerUpdateCallback");
-
-  onMounted(() => {
-    if (!registerUpdateCallback) {
-      throw new Error(
-        "Missing registerUpdateCallback - useUpdate must be used within a Screen component",
-      );
-    }
-
-    const unregister = registerUpdateCallback(callback);
-    onUnmounted(unregister);
-  });
-};